From d0ea3e84721009204ad289fe09eb8528459d48cc Mon Sep 17 00:00:00 2001
From: Dmitry Shibanov <dmitry-shibanov@github.com>
Date: Wed, 9 Feb 2022 13:02:58 +0300
Subject: [PATCH] resolve comments
---
README.md | 4 ++--
__tests__/setup-go.test.ts | 8 ++++----
dist/index.js | 2 +-
src/installer.ts | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/README.md b/README.md
index 46f9baf..0ecccd9 100644
--- a/README.md
+++ b/README.md
@@ -62,7 +62,7 @@ steps:
The `check-latest` flag defaults to `false`. Use the default or set `check-latest` to `false` if you prefer stability and if you want to ensure a specific Go version is always used.
-If `check-latest` is set to `true`, the action first checks if the cached version is the latest one. If the locally cached version is not the most up-to-date, a Go version will then be downloaded. Set `check-latest` to `true` it you want the most up-to-date Go version to always be used.
+If `check-latest` is set to `true`, the action first checks if the cached version is the latest one. If the locally cached version is not the most up-to-date, a Go version will then be downloaded. Set `check-latest` to `true` if you want the most up-to-date Go version to always be used.
> Setting `check-latest` to `true` has performance implications as downloading Go versions is slower than using cached versions.
@@ -76,7 +76,7 @@ steps:
- run: go run hello.go
```
-## Matrix Testing:
+## Matrix Testing:
```yaml
jobs:
build:
diff --git a/__tests__/setup-go.test.ts b/__tests__/setup-go.test.ts
index 1e64b17..db94e82 100644
--- a/__tests__/setup-go.test.ts
+++ b/__tests__/setup-go.test.ts
@@ -589,7 +589,7 @@ describe('setup-go', () => {
expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`);
expect(logSpy).not.toHaveBeenCalledWith(
- 'Attempt to resolve the latest version from manifest...'
+ 'Attempting to resolve the latest version from the manifest...'
);
});
@@ -636,7 +636,7 @@ describe('setup-go', () => {
`Setup go stable version spec ${versionSpec}`
);
expect(logSpy).toHaveBeenCalledWith(
- 'Attempt to resolve the latest version from manifest...'
+ 'Attempting to resolve the latest version from the manifest...'
);
expect(logSpy).toHaveBeenCalledWith(`Resolved as '${patchVersion}'`);
expect(logSpy).toHaveBeenCalledWith(
@@ -676,7 +676,7 @@ describe('setup-go', () => {
expect(dlSpy).toHaveBeenCalled();
expect(exSpy).toHaveBeenCalled();
expect(logSpy).toHaveBeenCalledWith(
- 'Attempt to resolve the latest version from manifest...'
+ 'Attempting to resolve the latest version from the manifest...'
);
expect(logSpy).toHaveBeenCalledWith(
`Failed to resolve version ${versionSpec} from manifest`
@@ -721,7 +721,7 @@ describe('setup-go', () => {
expect(dlSpy).toHaveBeenCalled();
expect(exSpy).toHaveBeenCalled();
expect(logSpy).toHaveBeenCalledWith(
- 'Attempt to resolve the latest version from manifest...'
+ 'Attempting to resolve the latest version from the manifest...'
);
expect(logSpy).toHaveBeenCalledWith(
'Unable to resolve a version from the manifest...'
diff --git a/dist/index.js b/dist/index.js
index a5d33fb..59a4067 100644
--- a/dist/index.js
+++ b/dist/index.js
@@ -5895,7 +5895,7 @@ function getGo(versionSpec, stable, checkLatest, auth) {
let osPlat = os_1.default.platform();
let osArch = os_1.default.arch();
if (checkLatest) {
- core.info('Attempt to resolve the latest version from manifest...');
+ core.info('Attempting to resolve the latest version from the manifest...');
const resolvedVersion = yield resolveVersionFromManifest(versionSpec, stable, auth);
if (resolvedVersion) {
versionSpec = resolvedVersion;
diff --git a/src/installer.ts b/src/installer.ts
index 99d6e1a..ee45c64 100644
--- a/src/installer.ts
+++ b/src/installer.ts
@@ -38,7 +38,7 @@ export async function getGo(
let osArch: string = os.arch();
if (checkLatest) {
- core.info('Attempt to resolve the latest version from manifest...');
+ core.info('Attempting to resolve the latest version from the manifest...');
const resolvedVersion = await resolveVersionFromManifest(
versionSpec,
stable,