From 7c9d5e4560169f071e1c02b747ed1fd5524fefe8 Mon Sep 17 00:00:00 2001
From: yanweidong <david.yan@qq.com>
Date: Fri, 24 Jul 2026 10:37:46 +0800
Subject: [PATCH] feat(explore): allow deleting source categories

---
 apps/web_v1/src/App.css                         | 5 +----
 apps/web_v1/src/pages/workspace-explore.tsx     | 4 +---
 backend/internal/logic/dataset/handlers.go      | 2 --
 backend/internal/logic/dataset/handlers_test.go | 7 +++++--
 backend/internal/logic/dataset/service.go       | 4 ----
 5 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/apps/web_v1/src/App.css b/apps/web_v1/src/App.css
index 392172b..a050f7e 100644
--- a/apps/web_v1/src/App.css
+++ b/apps/web_v1/src/App.css
@@ -710,6 +710,7 @@
 
 .explore-source-row {
   min-width: 0;
+  row-gap: 12px;
 }
 
 .explore-source-card.arco-card {
@@ -1078,10 +1079,6 @@
     max-width: 100%;
   }
 
-  .explore-source-row {
-    row-gap: 10px;
-  }
-
   .explore-reader-layout {
     grid-template-columns: minmax(0, 1fr);
   }
diff --git a/apps/web_v1/src/pages/workspace-explore.tsx b/apps/web_v1/src/pages/workspace-explore.tsx
index 15e56cf..45f3caa 100644
--- a/apps/web_v1/src/pages/workspace-explore.tsx
+++ b/apps/web_v1/src/pages/workspace-explore.tsx
@@ -372,9 +372,7 @@ export function WorkspaceExplorePage({
                 {source.id !== 'all' ? (
                   <span className="explore-source-actions" onClick={(event) => event.stopPropagation()}>
                     <Button aria-label={`编辑${source.name}`} type="text" size="mini" icon={<IconEdit />} onClick={() => openEditSource(source)} />
-                    {!source.builtIn ? (
-                      <Button aria-label={`删除${source.name}`} type="text" size="mini" status="danger" icon={<IconDelete />} onClick={() => deleteSource(source)} />
-                    ) : null}
+                    <Button aria-label={`删除${source.name}`} type="text" size="mini" status="danger" icon={<IconDelete />} onClick={() => deleteSource(source)} />
                   </span>
                 ) : null}
               </Card>
diff --git a/backend/internal/logic/dataset/handlers.go b/backend/internal/logic/dataset/handlers.go
index 409ce24..484f86c 100644
--- a/backend/internal/logic/dataset/handlers.go
+++ b/backend/internal/logic/dataset/handlers.go
@@ -341,8 +341,6 @@ func writeError(c *gin.Context, err error) {
 	switch {
 	case errors.Is(err, gorm.ErrRecordNotFound):
 		httpx.Error(c, http.StatusNotFound, "not_found", "数据源或数据条目不存在")
-	case errors.Is(err, ErrBuiltInSource):
-		httpx.Error(c, http.StatusConflict, "built_in_source", "内置数据源不能删除，可以将其停用")
 	case errors.Is(err, ErrSyncInProgress):
 		httpx.Error(c, http.StatusConflict, "sync_in_progress", "已有数据源采集任务正在运行")
 	case errors.Is(err, ErrNameRequired), errors.Is(err, ErrKindInvalid),
diff --git a/backend/internal/logic/dataset/handlers_test.go b/backend/internal/logic/dataset/handlers_test.go
index 36e2565..a2aec6d 100644
--- a/backend/internal/logic/dataset/handlers_test.go
+++ b/backend/internal/logic/dataset/handlers_test.go
@@ -196,7 +196,7 @@ func TestDatasetItemsArePaginatedByOwnedSource(t *testing.T) {
 	require.Len(t, page.Items, 2)
 }
 
-func TestBuiltInDatasetSourceKeepsManagedFieldsAndCannotBeDeleted(t *testing.T) {
+func TestBuiltInDatasetSourceKeepsManagedFieldsAndCanBeDeleted(t *testing.T) {
 	database := newDatasetTestDatabase(t)
 	owner := createDatasetTestUser(t, database, "owner@example.com")
 	seedKey := "built-in"
@@ -224,7 +224,10 @@ func TestBuiltInDatasetSourceKeepsManagedFieldsAndCannotBeDeleted(t *testing.T)
 	require.Equal(t, renamed, updated.Name)
 	require.False(t, updated.Enabled)
 	require.Equal(t, "https://example.com/feed", updated.URL)
-	require.ErrorIs(t, service.DeleteSource(owner.ID, source.Identity), ErrBuiltInSource)
+	require.NoError(t, service.DeleteSource(owner.ID, source.Identity))
+	var count int64
+	require.NoError(t, database.Model(&models.SaDatasetSource{}).Where("id = ?", source.ID).Count(&count).Error)
+	require.Zero(t, count)
 }
 
 func newDatasetTestDatabase(t *testing.T) *gorm.DB {
diff --git a/backend/internal/logic/dataset/service.go b/backend/internal/logic/dataset/service.go
index ff976bb..c7b23a2 100644
--- a/backend/internal/logic/dataset/service.go
+++ b/backend/internal/logic/dataset/service.go
@@ -20,7 +20,6 @@ var (
 	ErrURLInvalid     = errors.New("dataset source url is invalid")
 	ErrTitleRequired  = errors.New("dataset item title is required")
 	ErrStatusInvalid  = errors.New("dataset item status is invalid")
-	ErrBuiltInSource  = errors.New("built-in dataset source cannot be deleted")
 	ErrSyncInProgress = errors.New("dataset sync is already in progress")
 )
 
@@ -226,9 +225,6 @@ func (s *Service) DeleteSource(userID uint, identity string) error {
 		if err := tx.Where("identity = ? AND owner_id = ?", identity, userID).First(&source).Error; err != nil {
 			return err
 		}
-		if source.SeedKey != nil {
-			return ErrBuiltInSource
-		}
 		if err := tx.Where("source_id = ?", source.ID).Delete(&models.SaDatasetItem{}).Error; err != nil {
 			return err
 		}