refactor: simplify dataset source ownership

backend/internal/initdb/dataset.go

@@ -3,6 +3,7 @@ package initdb
 import (
 	"errors"
 	"fmt"
+	"strings"
 
 	"gorm.io/gorm"
 	"senlinai-agent/backend/internal/models"
@@ -59,28 +60,87 @@ func InitDataset(database *gorm.DB) error {
 }
 
 func prepareDatasetSourceOwners(tx *gorm.DB) error {
+	hasCreatedBy, err := hasDatasetSourceColumn(tx, "created_by")
+	if err != nil {
+		return err
+	}
+	if hasCreatedBy {
+		if err := tx.Exec(
+			"UPDATE sa_dataset_sources SET owner_id = created_by WHERE owner_id = 0",
+		).Error; err != nil {
+			return fmt.Errorf("backfill dataset source owners: %w", err)
+		}
+	}
+
 	var sources []models.SaDatasetSource
 	if err := tx.Where("owner_id = ? OR owner_identity = ?", 0, "").Find(&sources).Error; err != nil {
 		return err
 	}
 	for _, source := range sources {
-		ownerID := source.OwnerID
-		if ownerID == 0 {
-			ownerID = source.CreatedBy
-		}
 		var owner models.SaUser
-		if err := tx.Select("identity").First(&owner, ownerID).Error; err != nil {
+		if err := tx.Select("identity").First(&owner, source.OwnerID).Error; err != nil {
 			return err
 		}
 		if err := tx.Model(&source).Updates(map[string]any{
-			"owner_id": ownerID, "owner_identity": owner.Identity,
+			"owner_identity": owner.Identity,
 		}).Error; err != nil {
 			return err
 		}
 	}
+
+	if tx.Migrator().HasIndex(&models.SaDatasetSource{}, "idx_sa_dataset_source_seed") {
+		if err := tx.Migrator().DropIndex(&models.SaDatasetSource{}, "idx_sa_dataset_source_seed"); err != nil {
+			return fmt.Errorf("drop legacy dataset source seed index: %w", err)
+		}
+	}
+	for _, index := range []string{
+		"idx_sa_dataset_sources_created_by",
+		"idx_sa_dataset_sources_created_by_identity",
+	} {
+		if tx.Migrator().HasIndex(&models.SaDatasetSource{}, index) {
+			if err := tx.Migrator().DropIndex(&models.SaDatasetSource{}, index); err != nil {
+				return fmt.Errorf("drop legacy dataset source creator index %s: %w", index, err)
+			}
+		}
+	}
+	hasCreatedByIdentity, err := hasDatasetSourceColumn(tx, "created_by_identity")
+	if err != nil {
+		return err
+	}
+	if hasCreatedByIdentity {
+		if err := tx.Exec(
+			"ALTER TABLE sa_dataset_sources DROP COLUMN created_by_identity",
+		).Error; err != nil {
+			return fmt.Errorf("drop legacy dataset source creator identity: %w", err)
+		}
+	}
+	hasCreatedBy, err = hasDatasetSourceColumn(tx, "created_by")
+	if err != nil {
+		return err
+	}
+	if hasCreatedBy {
+		if err := tx.Exec(
+			"ALTER TABLE sa_dataset_sources DROP COLUMN created_by",
+		).Error; err != nil {
+			return fmt.Errorf("drop legacy dataset source creator: %w", err)
+		}
+	}
 	return nil
 }
 
+func hasDatasetSourceColumn(tx *gorm.DB, name string) (bool, error) {
+	columns, err := tx.Migrator().ColumnTypes(&models.SaDatasetSource{})
+	if err != nil {
+		return false, fmt.Errorf("inspect dataset source columns: %w", err)
+	}
+	for _, column := range columns {
+		if strings.EqualFold(column.Name(), name) {
+			return true, nil
+		}
+	}
+	return false, nil
+}
+
 func prepareDatasetItems(tx *gorm.DB) error {
 	if tx.Migrator().HasIndex(&models.SaDatasetItem{}, "idx_sa_dataset_item_source_external") {
 		return nil
@@ -135,7 +195,7 @@ func upsertDefaultDatasetSource(tx *gorm.DB, root models.SaUser, definition defa
 
 	seedKey := definition.Key
 	return tx.Create(&models.SaDatasetSource{
-		OwnerID: root.ID, CreatedBy: root.ID, SeedKey: &seedKey, Name: definition.Name,
+		OwnerID: root.ID, SeedKey: &seedKey, Name: definition.Name,
 		Kind: "rss", URL: definition.URL, IconURL: definition.IconURL,
 		Description: "默认资讯订阅", Enabled: true,
 	}).Error