refactor: remove dataset cron records
This commit is contained in:
@@ -7,13 +7,13 @@ import (
|
||||
"sync/atomic"
|
||||
"time"
|
||||
|
||||
"senlinai-agent/backend/internal/models"
|
||||
"senlinai-agent/backend/internal/logic/dataset"
|
||||
)
|
||||
|
||||
const datasetInterval = 5 * time.Minute
|
||||
var datasetInterval = 5 * time.Minute
|
||||
|
||||
type DatasetCollector interface {
|
||||
SyncAllSources(context.Context) ([]models.SaDatasetCron, error)
|
||||
SyncAllSources(context.Context) ([]dataset.SyncResult, error)
|
||||
}
|
||||
|
||||
type DatasetScheduler struct {
|
||||
@@ -70,11 +70,11 @@ func (s *DatasetScheduler) Run(ctx context.Context) {
|
||||
}
|
||||
|
||||
func (s *DatasetScheduler) collect(ctx context.Context) {
|
||||
crons, err := s.collector.SyncAllSources(ctx)
|
||||
results, err := s.collector.SyncAllSources(ctx)
|
||||
completed := 0
|
||||
failed := 0
|
||||
for _, cron := range crons {
|
||||
switch cron.Status {
|
||||
for _, result := range results {
|
||||
switch result.Status {
|
||||
case "completed":
|
||||
completed++
|
||||
case "failed":
|
||||
@@ -82,8 +82,8 @@ func (s *DatasetScheduler) collect(ctx context.Context) {
|
||||
}
|
||||
}
|
||||
if err != nil {
|
||||
s.logger.Printf("dataset collection failed: tasks=%d completed=%d failed=%d error=%v", len(crons), completed, failed, err)
|
||||
s.logger.Printf("dataset collection failed: sources=%d completed=%d failed=%d error=%v", len(results), completed, failed, err)
|
||||
return
|
||||
}
|
||||
s.logger.Printf("dataset collection finished: tasks=%d completed=%d failed=%d", len(crons), completed, failed)
|
||||
s.logger.Printf("dataset collection finished: sources=%d completed=%d failed=%d", len(results), completed, failed)
|
||||
}
|
||||
|
||||
@@ -9,7 +9,7 @@ import (
|
||||
"time"
|
||||
|
||||
"github.com/stretchr/testify/require"
|
||||
"senlinai-agent/backend/internal/models"
|
||||
"senlinai-agent/backend/internal/logic/dataset"
|
||||
)
|
||||
|
||||
func TestDatasetSchedulerCollectsImmediatelyAndRepeats(t *testing.T) {
|
||||
@@ -95,13 +95,13 @@ type recordingDatasetCollector struct {
|
||||
calls chan time.Time
|
||||
}
|
||||
|
||||
func (c *recordingDatasetCollector) SyncAllSources(context.Context) ([]models.SaDatasetCron, error) {
|
||||
func (c *recordingDatasetCollector) SyncAllSources(context.Context) ([]dataset.SyncResult, error) {
|
||||
now := time.Now()
|
||||
c.mu.Lock()
|
||||
c.count++
|
||||
c.mu.Unlock()
|
||||
c.calls <- now
|
||||
return []models.SaDatasetCron{{Status: "completed"}}, nil
|
||||
return []dataset.SyncResult{{Status: "completed"}}, nil
|
||||
}
|
||||
|
||||
func (c *recordingDatasetCollector) callCount() int {
|
||||
@@ -128,7 +128,7 @@ type blockingDatasetCollector struct {
|
||||
release chan struct{}
|
||||
}
|
||||
|
||||
func (c *blockingDatasetCollector) SyncAllSources(ctx context.Context) ([]models.SaDatasetCron, error) {
|
||||
func (c *blockingDatasetCollector) SyncAllSources(ctx context.Context) ([]dataset.SyncResult, error) {
|
||||
c.mu.Lock()
|
||||
c.count++
|
||||
c.mu.Unlock()
|
||||
|
||||
@@ -7,7 +7,6 @@ import (
|
||||
"net/url"
|
||||
"os"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/stretchr/testify/require"
|
||||
"senlinai-agent/backend/internal/models"
|
||||
@@ -136,13 +135,12 @@ func TestSyncSourcesRecordsFeedFailure(t *testing.T) {
|
||||
}
|
||||
require.NoError(t, database.Create(&source).Error)
|
||||
|
||||
crons, err := newServiceWithFetcher(database, failingFeedFetcher{}).SyncSources(context.Background(), user.ID)
|
||||
results, err := newServiceWithFetcher(database, failingFeedFetcher{}).SyncSources(context.Background(), user.ID)
|
||||
|
||||
require.NoError(t, err)
|
||||
require.Len(t, crons, 1)
|
||||
require.Equal(t, "failed", crons[0].Status)
|
||||
require.False(t, crons[0].Enabled)
|
||||
require.Contains(t, crons[0].LastResult, "feed unavailable")
|
||||
require.Len(t, results, 1)
|
||||
require.Equal(t, "failed", results[0].Status)
|
||||
require.Contains(t, results[0].Result, "feed unavailable")
|
||||
}
|
||||
|
||||
func TestSyncAllSourcesCollectsEnabledRSSSourcesForEveryUser(t *testing.T) {
|
||||
@@ -157,10 +155,10 @@ func TestSyncAllSourcesCollectsEnabledRSSSourcesForEveryUser(t *testing.T) {
|
||||
require.NoError(t, database.Create(&source).Error)
|
||||
}
|
||||
|
||||
crons, err := newServiceWithFetcher(database, staticFeedFetcher{}).SyncAllSources(context.Background())
|
||||
results, err := newServiceWithFetcher(database, staticFeedFetcher{}).SyncAllSources(context.Background())
|
||||
|
||||
require.NoError(t, err)
|
||||
require.Len(t, crons, 2)
|
||||
require.Len(t, results, 2)
|
||||
var itemCount int64
|
||||
require.NoError(t, database.Model(&models.SaDatasetItem{}).Count(&itemCount).Error)
|
||||
require.Equal(t, int64(2), itemCount)
|
||||
@@ -185,7 +183,7 @@ func TestSyncSourcesCollectsMultipleSourcesForOneOwner(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestQueueSourcesRunsInBackgroundAndRejectsOverlap(t *testing.T) {
|
||||
func TestSyncSourcesRejectsOverlap(t *testing.T) {
|
||||
database := newDatasetTestDatabase(t)
|
||||
user := createDatasetTestUser(t, database, "queued-feed-owner@example.com")
|
||||
source := models.SaDatasetSource{
|
||||
@@ -199,20 +197,24 @@ func TestQueueSourcesRunsInBackgroundAndRejectsOverlap(t *testing.T) {
|
||||
}
|
||||
service := newServiceWithFetcher(database, fetcher)
|
||||
|
||||
queued, err := service.QueueSources(user.ID)
|
||||
|
||||
require.NoError(t, err)
|
||||
require.Len(t, queued, 1)
|
||||
require.Equal(t, "pending", queued[0].Status)
|
||||
type syncOutcome struct {
|
||||
results []SyncResult
|
||||
err error
|
||||
}
|
||||
done := make(chan syncOutcome, 1)
|
||||
go func() {
|
||||
results, err := service.SyncSources(context.Background(), user.ID)
|
||||
done <- syncOutcome{results: results, err: err}
|
||||
}()
|
||||
<-fetcher.started
|
||||
_, err = service.QueueSources(user.ID)
|
||||
_, err := service.SyncSources(context.Background(), user.ID)
|
||||
require.ErrorIs(t, err, ErrSyncInProgress)
|
||||
require.ErrorIs(t, service.DeleteSource(user.ID, source.Identity), ErrSyncInProgress)
|
||||
close(fetcher.release)
|
||||
require.Eventually(t, func() bool {
|
||||
runs, listErr := service.ListCrons(user.ID)
|
||||
return listErr == nil && len(runs) == 1 && runs[0].Status == "completed"
|
||||
}, time.Second, 10*time.Millisecond)
|
||||
outcome := <-done
|
||||
require.NoError(t, outcome.err)
|
||||
require.Len(t, outcome.results, 1)
|
||||
require.Equal(t, "completed", outcome.results[0].Status)
|
||||
}
|
||||
|
||||
type failingFeedFetcher struct{}
|
||||
|
||||
@@ -54,14 +54,10 @@ type ItemPageDTO struct {
|
||||
Offset int `json:"offset"`
|
||||
}
|
||||
|
||||
type CronDTO struct {
|
||||
ID string `json:"id"`
|
||||
SourceID string `json:"sourceId"`
|
||||
Status string `json:"status"`
|
||||
LastRunAt *time.Time `json:"lastRunAt"`
|
||||
LastResult string `json:"lastResult"`
|
||||
CreatedAt time.Time `json:"createdAt"`
|
||||
UpdatedAt time.Time `json:"updatedAt"`
|
||||
type SyncResultDTO struct {
|
||||
SourceID string `json:"sourceId"`
|
||||
Status string `json:"status"`
|
||||
Result string `json:"result"`
|
||||
}
|
||||
|
||||
type DepositDTO struct {
|
||||
@@ -91,8 +87,7 @@ func (h *Handler) Register(router gin.IRouter) {
|
||||
router.POST("/dataset-items", h.createItem)
|
||||
router.PATCH("/dataset-items/:id", h.updateItem)
|
||||
router.POST("/dataset-items/:id/deposit", h.depositItem)
|
||||
router.GET("/dataset-crons", h.listCrons)
|
||||
router.POST("/dataset-crons/sync", h.queueSync)
|
||||
router.POST("/dataset-sources/sync", h.syncSources)
|
||||
}
|
||||
|
||||
func (h *Handler) listSources(c *gin.Context) {
|
||||
@@ -309,38 +304,25 @@ func (h *Handler) depositItem(c *gin.Context) {
|
||||
})
|
||||
}
|
||||
|
||||
func (h *Handler) listCrons(c *gin.Context) {
|
||||
func (h *Handler) syncSources(c *gin.Context) {
|
||||
userID, ok := currentUser(c)
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
crons, err := h.service.ListCrons(userID)
|
||||
results, err := h.service.SyncSources(c.Request.Context(), userID)
|
||||
if err != nil {
|
||||
writeError(c, err)
|
||||
return
|
||||
}
|
||||
result := make([]CronDTO, 0, len(crons))
|
||||
for _, cron := range crons {
|
||||
result = append(result, cronDTO(cron))
|
||||
response := make([]SyncResultDTO, 0, len(results))
|
||||
for _, result := range results {
|
||||
response = append(response, SyncResultDTO{
|
||||
SourceID: result.SourceIdentity,
|
||||
Status: result.Status,
|
||||
Result: result.Result,
|
||||
})
|
||||
}
|
||||
c.JSON(http.StatusOK, result)
|
||||
}
|
||||
|
||||
func (h *Handler) queueSync(c *gin.Context) {
|
||||
userID, ok := currentUser(c)
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
crons, err := h.service.QueueSources(userID)
|
||||
if err != nil {
|
||||
writeError(c, err)
|
||||
return
|
||||
}
|
||||
result := make([]CronDTO, 0, len(crons))
|
||||
for _, cron := range crons {
|
||||
result = append(result, cronDTO(cron))
|
||||
}
|
||||
c.JSON(http.StatusAccepted, result)
|
||||
c.JSON(http.StatusOK, response)
|
||||
}
|
||||
|
||||
func currentUser(c *gin.Context) (uint, bool) {
|
||||
@@ -390,14 +372,6 @@ func itemDTO(item models.SaDatasetItem) ItemDTO {
|
||||
}
|
||||
}
|
||||
|
||||
func cronDTO(cron models.SaDatasetCron) CronDTO {
|
||||
return CronDTO{
|
||||
ID: cron.Identity, SourceID: cron.SourceIdentity, Status: cron.Status,
|
||||
LastRunAt: utcTime(cron.LastRunAt), LastResult: cron.LastResult,
|
||||
CreatedAt: cron.CreatedAt.UTC(), UpdatedAt: cron.UpdatedAt.UTC(),
|
||||
}
|
||||
}
|
||||
|
||||
func optionalNonNegativeInt(value string) (int, error) {
|
||||
if strings.TrimSpace(value) == "" {
|
||||
return 0, nil
|
||||
|
||||
@@ -8,7 +8,6 @@ import (
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/glebarez/sqlite"
|
||||
"github.com/stretchr/testify/require"
|
||||
@@ -95,25 +94,20 @@ func TestDatasetAPIConnectsSourcesItemsAndSyncTasks(t *testing.T) {
|
||||
require.Equal(t, item.Title, depositedNote.Title)
|
||||
require.Contains(t, depositedNote.Markdown, "原文链接")
|
||||
|
||||
firstSync := performDatasetRequest(t, ownerRouter, http.MethodPost, "/api/v1/dataset-crons/sync", map[string]any{})
|
||||
require.Equal(t, http.StatusAccepted, firstSync.Code)
|
||||
var firstCrons []CronDTO
|
||||
require.NoError(t, json.Unmarshal(firstSync.Body.Bytes(), &firstCrons))
|
||||
require.Len(t, firstCrons, 1)
|
||||
require.Equal(t, "pending", firstCrons[0].Status)
|
||||
firstCompleted := waitForDatasetRun(t, ownerRouter, firstCrons[0].ID)
|
||||
require.Equal(t, "completed", firstCompleted.Status)
|
||||
require.Contains(t, firstCompleted.LastResult, "format=rss")
|
||||
firstSync := performDatasetRequest(t, ownerRouter, http.MethodPost, "/api/v1/dataset-sources/sync", map[string]any{})
|
||||
require.Equal(t, http.StatusOK, firstSync.Code)
|
||||
var firstResults []SyncResultDTO
|
||||
require.NoError(t, json.Unmarshal(firstSync.Body.Bytes(), &firstResults))
|
||||
require.Len(t, firstResults, 1)
|
||||
require.Equal(t, "completed", firstResults[0].Status)
|
||||
require.Contains(t, firstResults[0].Result, "format=rss")
|
||||
|
||||
var secondSync *httptest.ResponseRecorder
|
||||
require.Eventually(t, func() bool {
|
||||
secondSync = performDatasetRequest(t, ownerRouter, http.MethodPost, "/api/v1/dataset-crons/sync", map[string]any{})
|
||||
return secondSync.Code == http.StatusAccepted
|
||||
}, time.Second, 10*time.Millisecond)
|
||||
var secondCrons []CronDTO
|
||||
require.NoError(t, json.Unmarshal(secondSync.Body.Bytes(), &secondCrons))
|
||||
require.NotEqual(t, firstCrons[0].ID, secondCrons[0].ID)
|
||||
waitForDatasetRun(t, ownerRouter, secondCrons[0].ID)
|
||||
secondSync := performDatasetRequest(t, ownerRouter, http.MethodPost, "/api/v1/dataset-sources/sync", map[string]any{})
|
||||
require.Equal(t, http.StatusOK, secondSync.Code)
|
||||
var secondResults []SyncResultDTO
|
||||
require.NoError(t, json.Unmarshal(secondSync.Body.Bytes(), &secondResults))
|
||||
require.Len(t, secondResults, 1)
|
||||
require.Equal(t, "completed", secondResults[0].Status)
|
||||
var collectedItems []models.SaDatasetItem
|
||||
require.NoError(t, database.Where("source_id = ?", 1).Find(&collectedItems).Error)
|
||||
require.Len(t, collectedItems, 2)
|
||||
@@ -129,11 +123,9 @@ func TestDatasetAPIConnectsSourcesItemsAndSyncTasks(t *testing.T) {
|
||||
|
||||
deleted := performDatasetRequest(t, ownerRouter, http.MethodDelete, "/api/v1/dataset-sources/"+source.ID, nil)
|
||||
require.Equal(t, http.StatusNoContent, deleted.Code)
|
||||
var itemCount, cronCount int64
|
||||
var itemCount int64
|
||||
require.NoError(t, database.Model(&models.SaDatasetItem{}).Count(&itemCount).Error)
|
||||
require.NoError(t, database.Model(&models.SaDatasetCron{}).Count(&cronCount).Error)
|
||||
require.Zero(t, itemCount)
|
||||
require.Zero(t, cronCount)
|
||||
}
|
||||
|
||||
func TestDatasetSourceAuthorizationUsesOwner(t *testing.T) {
|
||||
@@ -241,7 +233,6 @@ func newDatasetTestDatabase(t *testing.T) *gorm.DB {
|
||||
&models.SaUser{},
|
||||
&models.SaDatasetSource{},
|
||||
&models.SaDatasetItem{},
|
||||
&models.SaDatasetCron{},
|
||||
&models.SaProject{},
|
||||
&models.SaNote{},
|
||||
))
|
||||
@@ -252,29 +243,6 @@ func newDatasetTestDatabase(t *testing.T) *gorm.DB {
|
||||
return database
|
||||
}
|
||||
|
||||
func waitForDatasetRun(t *testing.T, router http.Handler, identity string) CronDTO {
|
||||
t.Helper()
|
||||
var completed CronDTO
|
||||
require.Eventually(t, func() bool {
|
||||
response := performDatasetRequest(t, router, http.MethodGet, "/api/v1/dataset-crons", nil)
|
||||
if response.Code != http.StatusOK {
|
||||
return false
|
||||
}
|
||||
var runs []CronDTO
|
||||
if json.Unmarshal(response.Body.Bytes(), &runs) != nil {
|
||||
return false
|
||||
}
|
||||
for _, run := range runs {
|
||||
if run.ID == identity && (run.Status == "completed" || run.Status == "failed") {
|
||||
completed = run
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}, time.Second, 10*time.Millisecond)
|
||||
return completed
|
||||
}
|
||||
|
||||
func createDatasetTestUser(t *testing.T, database *gorm.DB, email string) models.SaUser {
|
||||
t.Helper()
|
||||
user := models.SaUser{Email: email, DisplayName: email, PasswordHash: "hash", Role: "user"}
|
||||
|
||||
@@ -27,7 +27,6 @@ var (
|
||||
const (
|
||||
defaultItemPageSize = 50
|
||||
maxItemPageSize = 200
|
||||
datasetRunRetention = 30 * 24 * time.Hour
|
||||
maxConcurrentFetches = 4
|
||||
)
|
||||
|
||||
@@ -91,9 +90,10 @@ type ItemPage struct {
|
||||
Offset int
|
||||
}
|
||||
|
||||
type queuedSource struct {
|
||||
Source models.SaDatasetSource
|
||||
Run models.SaDatasetCron
|
||||
type SyncResult struct {
|
||||
SourceIdentity string
|
||||
Status string
|
||||
Result string
|
||||
}
|
||||
|
||||
func NewService(database *gorm.DB) *Service {
|
||||
@@ -228,9 +228,6 @@ func (s *Service) DeleteSource(userID uint, identity string) error {
|
||||
if source.SeedKey != nil {
|
||||
return ErrBuiltInSource
|
||||
}
|
||||
if err := tx.Where("source_id = ?", source.ID).Delete(&models.SaDatasetCron{}).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
if err := tx.Where("source_id = ?", source.ID).Delete(&models.SaDatasetItem{}).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
@@ -363,93 +360,32 @@ func (s *Service) DepositItem(userID uint, itemIdentity, projectIdentity string)
|
||||
return DepositResult{NoteIdentity: note.Identity, ProjectIdentity: project.Identity}, nil
|
||||
}
|
||||
|
||||
func (s *Service) ListCrons(userID uint) ([]models.SaDatasetCron, error) {
|
||||
var crons []models.SaDatasetCron
|
||||
if err := s.db.Model(&models.SaDatasetCron{}).
|
||||
Select("sa_dataset_crons.*").
|
||||
Joins("JOIN sa_dataset_sources ON sa_dataset_sources.id = sa_dataset_crons.source_id").
|
||||
Where("sa_dataset_sources.owner_id = ?", userID).
|
||||
Order("sa_dataset_crons.created_at desc, sa_dataset_crons.id desc").
|
||||
Limit(100).Find(&crons).Error; err != nil {
|
||||
return nil, err
|
||||
}
|
||||
if crons == nil {
|
||||
crons = []models.SaDatasetCron{}
|
||||
}
|
||||
return crons, nil
|
||||
}
|
||||
|
||||
func (s *Service) SyncSources(ctx context.Context, userID uint) ([]models.SaDatasetCron, error) {
|
||||
s.syncMu.Lock()
|
||||
defer s.syncMu.Unlock()
|
||||
|
||||
return s.syncSources(ctx, userID, "scheduled")
|
||||
}
|
||||
|
||||
func (s *Service) QueueSources(userID uint) ([]models.SaDatasetCron, error) {
|
||||
func (s *Service) SyncSources(ctx context.Context, userID uint) ([]SyncResult, error) {
|
||||
if !s.syncMu.TryLock() {
|
||||
return nil, ErrSyncInProgress
|
||||
}
|
||||
sources, err := s.enabledRSSSources(userID)
|
||||
if err != nil {
|
||||
s.syncMu.Unlock()
|
||||
return nil, err
|
||||
}
|
||||
queued, err := s.createDatasetRuns(userID, sources, "manual")
|
||||
if err != nil {
|
||||
s.syncMu.Unlock()
|
||||
return nil, err
|
||||
}
|
||||
runs := make([]models.SaDatasetCron, 0, len(queued))
|
||||
for _, entry := range queued {
|
||||
runs = append(runs, entry.Run)
|
||||
}
|
||||
if len(queued) == 0 {
|
||||
s.syncMu.Unlock()
|
||||
return runs, nil
|
||||
}
|
||||
go func() {
|
||||
defer s.syncMu.Unlock()
|
||||
_, _ = s.executeDatasetRuns(context.Background(), queued)
|
||||
}()
|
||||
return runs, nil
|
||||
}
|
||||
defer s.syncMu.Unlock()
|
||||
|
||||
func (s *Service) SyncAllSources(ctx context.Context) ([]models.SaDatasetCron, error) {
|
||||
var userIDs []uint
|
||||
if err := s.db.Model(&models.SaDatasetSource{}).
|
||||
Distinct("owner_id").
|
||||
Where("enabled = ? AND kind = ?", true, "rss").
|
||||
Order("owner_id asc").
|
||||
Pluck("owner_id", &userIDs).Error; err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
result := make([]models.SaDatasetCron, 0)
|
||||
var syncErrors []error
|
||||
for _, userID := range userIDs {
|
||||
crons, err := s.SyncSources(ctx, userID)
|
||||
result = append(result, crons...)
|
||||
if err != nil {
|
||||
syncErrors = append(syncErrors, fmt.Errorf("sync dataset sources for user %d: %w", userID, err))
|
||||
}
|
||||
if ctx.Err() != nil {
|
||||
break
|
||||
}
|
||||
}
|
||||
return result, errors.Join(syncErrors...)
|
||||
}
|
||||
|
||||
func (s *Service) syncSources(ctx context.Context, userID uint, trigger string) ([]models.SaDatasetCron, error) {
|
||||
sources, err := s.enabledRSSSources(userID)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
queued, err := s.createDatasetRuns(userID, sources, trigger)
|
||||
if err != nil {
|
||||
return s.executeDatasetSources(ctx, sources)
|
||||
}
|
||||
|
||||
func (s *Service) SyncAllSources(ctx context.Context) ([]SyncResult, error) {
|
||||
if !s.syncMu.TryLock() {
|
||||
return nil, ErrSyncInProgress
|
||||
}
|
||||
defer s.syncMu.Unlock()
|
||||
|
||||
var sources []models.SaDatasetSource
|
||||
if err := s.db.Where("enabled = ? AND kind = ?", true, "rss").
|
||||
Order("owner_id asc, id asc").
|
||||
Find(&sources).Error; err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return s.executeDatasetRuns(ctx, queued)
|
||||
return s.executeDatasetSources(ctx, sources)
|
||||
}
|
||||
|
||||
func (s *Service) enabledRSSSources(userID uint) ([]models.SaDatasetSource, error) {
|
||||
@@ -461,78 +397,41 @@ func (s *Service) enabledRSSSources(userID uint) ([]models.SaDatasetSource, erro
|
||||
return sources, nil
|
||||
}
|
||||
|
||||
func (s *Service) createDatasetRuns(userID uint, sources []models.SaDatasetSource, trigger string) ([]queuedSource, error) {
|
||||
queued := make([]queuedSource, 0, len(sources))
|
||||
now := time.Now().UTC()
|
||||
err := s.db.Transaction(func(tx *gorm.DB) error {
|
||||
if err := tx.Where("created_at < ?", now.Add(-datasetRunRetention)).
|
||||
Delete(&models.SaDatasetCron{}).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
for _, source := range sources {
|
||||
run := models.SaDatasetCron{
|
||||
SourceID: source.ID, CreatedBy: userID, Schedule: trigger,
|
||||
Status: "pending", Enabled: true, NextRunAt: &now,
|
||||
}
|
||||
if err := tx.Create(&run).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
queued = append(queued, queuedSource{Source: source, Run: run})
|
||||
}
|
||||
return nil
|
||||
})
|
||||
return queued, err
|
||||
}
|
||||
|
||||
func (s *Service) executeDatasetRuns(ctx context.Context, queued []queuedSource) ([]models.SaDatasetCron, error) {
|
||||
result := make([]models.SaDatasetCron, len(queued))
|
||||
runErrors := make([]error, len(queued))
|
||||
func (s *Service) executeDatasetSources(ctx context.Context, sources []models.SaDatasetSource) ([]SyncResult, error) {
|
||||
result := make([]SyncResult, len(sources))
|
||||
runErrors := make([]error, len(sources))
|
||||
concurrency := maxConcurrentFetches
|
||||
if s.db.Dialector.Name() == "sqlite" {
|
||||
concurrency = 1
|
||||
}
|
||||
semaphore := make(chan struct{}, concurrency)
|
||||
var workers sync.WaitGroup
|
||||
for index, entry := range queued {
|
||||
for index, source := range sources {
|
||||
workers.Add(1)
|
||||
go func() {
|
||||
defer workers.Done()
|
||||
semaphore <- struct{}{}
|
||||
defer func() { <-semaphore }()
|
||||
result[index], runErrors[index] = s.executeDatasetRun(ctx, entry)
|
||||
result[index], runErrors[index] = s.executeDatasetSource(ctx, source)
|
||||
}()
|
||||
}
|
||||
workers.Wait()
|
||||
return result, errors.Join(runErrors...)
|
||||
}
|
||||
|
||||
func (s *Service) executeDatasetRun(ctx context.Context, entry queuedSource) (models.SaDatasetCron, error) {
|
||||
source := entry.Source
|
||||
cron := entry.Run
|
||||
func (s *Service) executeDatasetSource(ctx context.Context, source models.SaDatasetSource) (SyncResult, error) {
|
||||
result := SyncResult{SourceIdentity: source.Identity}
|
||||
if err := ctx.Err(); err != nil {
|
||||
return cron, err
|
||||
}
|
||||
now := time.Now().UTC()
|
||||
cron.Status = "running"
|
||||
cron.LastRunAt = &now
|
||||
if err := s.db.Model(&cron).Updates(map[string]any{
|
||||
"status": "running", "last_run_at": now,
|
||||
}).Error; err != nil {
|
||||
return cron, err
|
||||
result.Status = "failed"
|
||||
result.Result = truncateResult(err.Error())
|
||||
return result, err
|
||||
}
|
||||
|
||||
feed, fetchErr := s.fetcher.Fetch(ctx, source.URL)
|
||||
if fetchErr != nil {
|
||||
cron.Status = "failed"
|
||||
cron.Enabled = false
|
||||
cron.NextRunAt = nil
|
||||
cron.LastResult = truncateResult(fetchErr.Error())
|
||||
if err := s.db.Model(&cron).Updates(map[string]any{
|
||||
"status": cron.Status, "last_result": cron.LastResult, "enabled": false, "next_run_at": nil,
|
||||
}).Error; err != nil {
|
||||
return cron, err
|
||||
}
|
||||
return cron, ctx.Err()
|
||||
result.Status = "failed"
|
||||
result.Result = truncateResult(fetchErr.Error())
|
||||
return result, nil
|
||||
}
|
||||
|
||||
inserted := 0
|
||||
@@ -543,30 +442,16 @@ func (s *Service) executeDatasetRun(ctx context.Context, entry queuedSource) (mo
|
||||
if storeErr != nil {
|
||||
return storeErr
|
||||
}
|
||||
cron.Status = "completed"
|
||||
cron.Enabled = false
|
||||
cron.NextRunAt = nil
|
||||
cron.LastResult = fmt.Sprintf("format=%s fetched=%d inserted=%d", feed.Format, len(feed.Items), inserted)
|
||||
if err := tx.Model(&cron).Updates(map[string]any{
|
||||
"status": cron.Status, "last_result": cron.LastResult, "enabled": false, "next_run_at": nil,
|
||||
}).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
return tx.Model(&source).Update("last_synced_at", completedAt).Error
|
||||
})
|
||||
if err == nil {
|
||||
return cron, nil
|
||||
if err != nil {
|
||||
result.Status = "failed"
|
||||
result.Result = truncateResult("store feed items: " + err.Error())
|
||||
return result, nil
|
||||
}
|
||||
cron.Status = "failed"
|
||||
cron.Enabled = false
|
||||
cron.NextRunAt = nil
|
||||
cron.LastResult = truncateResult("store feed items: " + err.Error())
|
||||
if updateErr := s.db.Model(&cron).Updates(map[string]any{
|
||||
"status": cron.Status, "last_result": cron.LastResult, "enabled": false, "next_run_at": nil,
|
||||
}).Error; updateErr != nil {
|
||||
return cron, updateErr
|
||||
}
|
||||
return cron, nil
|
||||
result.Status = "completed"
|
||||
result.Result = fmt.Sprintf("format=%s fetched=%d inserted=%d", feed.Format, len(feed.Items), inserted)
|
||||
return result, nil
|
||||
}
|
||||
|
||||
func storeFeedItems(tx *gorm.DB, source models.SaDatasetSource, items []FeedItem) (int, error) {
|
||||
|
||||
@@ -1,24 +0,0 @@
|
||||
package models
|
||||
|
||||
import "time"
|
||||
|
||||
type SaDatasetCron struct {
|
||||
ID uint `gorm:"primaryKey"`
|
||||
Identity string `gorm:"type:char(36);uniqueIndex"`
|
||||
SourceID uint `gorm:"index;not null"`
|
||||
SourceIdentity string `gorm:"type:char(36);index"`
|
||||
CreatedBy uint `gorm:"index;not null"`
|
||||
CreatedByIdentity string `gorm:"type:char(36);index"`
|
||||
Schedule string `gorm:"size:100;not null"`
|
||||
Status string `gorm:"size:32;not null;default:pending;index"`
|
||||
Enabled bool `gorm:"not null;default:true;index"`
|
||||
NextRunAt *time.Time
|
||||
LastRunAt *time.Time
|
||||
LastResult string `gorm:"type:text"`
|
||||
CreatedAt time.Time `gorm:"index"`
|
||||
UpdatedAt time.Time
|
||||
}
|
||||
|
||||
func (SaDatasetCron) TableName() string {
|
||||
return "sa_dataset_crons"
|
||||
}
|
||||
@@ -36,16 +36,6 @@ func (m *SaDatasetItem) BeforeCreate(tx *gorm.DB) error {
|
||||
return resolveIdentity(tx, &SaDatasetSource{}, m.SourceID, &m.SourceIdentity)
|
||||
}
|
||||
|
||||
func (m *SaDatasetCron) BeforeCreate(tx *gorm.DB) error {
|
||||
if err := ensureIdentity(&m.Identity); err != nil {
|
||||
return err
|
||||
}
|
||||
if err := resolveIdentity(tx, &SaDatasetSource{}, m.SourceID, &m.SourceIdentity); err != nil {
|
||||
return err
|
||||
}
|
||||
return resolveIdentity(tx, &SaUser{}, m.CreatedBy, &m.CreatedByIdentity)
|
||||
}
|
||||
|
||||
func (m *SaInboxItem) BeforeCreate(tx *gorm.DB) error {
|
||||
if err := ensureIdentity(&m.Identity); err != nil {
|
||||
return err
|
||||
|
||||
@@ -33,7 +33,6 @@ func AutoMigrate(database *gorm.DB) error {
|
||||
&SaProject{},
|
||||
&SaDatasetSource{},
|
||||
&SaDatasetItem{},
|
||||
&SaDatasetCron{},
|
||||
&SaInboxItem{},
|
||||
&SaInboxSuggestion{},
|
||||
&SaTask{},
|
||||
|
||||
Reference in New Issue
Block a user