1.4 KiB
1.4 KiB
Final Fix 3 Report
Status
Completed the two final re-review fixes for the Discord-style project workbench UI.
Fixes
- Made ObjectInspector and CustomLinkChannel clipboard handlers await
navigator.clipboard.writeText, show success only after resolution, and show distinct unavailable or failure feedback otherwise. - Added focused ObjectInspector coverage for delayed success, rejection, and a missing clipboard API, plus CustomLinkChannel unavailable-clipboard coverage.
- Tightened ServerLogin validation for malformed HTTP slash forms, credentials, missing/repeated/invalid hostname labels, whitespace including encoded whitespace, and unsupported protocols while preserving localhost, IPv4, domain, port, and protocol-less normalization.
- Added unit and Playwright coverage for the requested malformed server-address cases.
TDD Evidence
- Added the regression tests before production changes.
- Ran the targeted test set and observed 10 expected failures: six malformed addresses were accepted and clipboard actions reported false success.
- Implemented the minimal validation and asynchronous clipboard handling.
- Re-ran the targeted test set successfully: 3 files, 26 tests passed.
Verification
From apps/web:
npm test -- --runpassed: 8 files, 40 tests.npm run buildpassed.npx playwright testpassed: 6 tests.git diff --checkpassed.
Concerns
None. Existing untracked SDD artifacts were left untouched.